Fixing pyannote-metrics.py for identification task, and fixing documentation references to pyannote-metrics.py script.

pyannote / pyannote-metrics

A toolkit for reproducible evaluation, diagnostic, and error analysis of speaker diarization systems

http://pyannote.github.io/pyannote-metrics

MIT License

183 stars 30 forks source link

Fixing pyannote-metrics.py for identification task, and fixing documentation references to pyannote-metrics.py script. #47

Closed hadware closed 4 years ago

hadware commented 4 years ago

There was a small bug in the printing of identification error rate results that made the script crash.
The script call example in the doc wasn't using the right name for the script.

Maybe (and just maybe) I could switch (in this PR) the script to an endpoint to match the other pyannote commands? I find it a tad upsetting that this script is called with a .py (but it's not too bad, I still sleep well at night).

hbredin commented 4 years ago

Thanks. Please go ahead: make it an endpoint and remove this pesky .py 👍

hadware commented 4 years ago

This should be ready to merge.

hbredin commented 4 years ago

Thanks.

Can you please move pyannote.metrics.applications.pyannote_metrics to pyannote.metrics.cli?

This will be coherent with upcoming pyannote.database.cli's pyannote-database command.

hadware commented 4 years ago

I think eveything should be good now?

hbredin commented 4 years ago

🥳

hbredin commented 4 years ago

FYI, I just released v3.0, that includes this PR:

http://pyannote.github.io/pyannote-metrics/cli.html#command-line-tool

hadware commented 4 years ago

Nice! now I can only wait for fame and glory.