Invalid mods flagged as incompatible

briermay commented 8 months ago

Mod source

Factorio Mod Portal

Which mod are you having an issue with?

[ ] pyalienlife
[ ] pyalternativeenergy
[X] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[X] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[X] Other

What is the problem?

Flagging a mod as incompatible just because you guys don't like it is just WRONG. beacon rebalance works just fine. Having to unzip the mod and hack the code to use another mod I like simply because one of you think it shouldn't be used is an abominal offense to coding standards.

Steps to reproduce

install beacon rebalanace and all py mods are disable due to it being flagged as incompatible when its perfectly compatible.

Additional context

mod authors should never falsely flag a mod just because of their views and only flag a mod as incomptible if its TRULY incompatible.

Log file

No response

notnotmelon commented 8 months ago

Please read the pY codex. We already have a custom system of beacons. Beacon rebalance does not function with our system.

oorzkws commented 8 months ago

It's actually more than "you guys don't like it", it's because we have a different system that's not only already similar to this but it requires beacons to be able to overlap or not overlap based on the AM/FM settings (our system).

If you take the git blame from the info.json line marking the beacon overhaul as incompatible, you will see the explanation for the beacon changes that were implemented at the same time: https://github.com/pyanodon/pycoalprocessing/commit/1c06c8e0075bbaecb0d285cd9dfab62707d39adb

Septiple commented 8 months ago

For posterity, I’m just going to note that the author of the commit linked earlier that added the incompatibility, notnotmelon, is literally also the author of beacon rebalance. So it’s really not because we don’t like that mod.

briermay commented 8 months ago

hmm you say this, but I have made my own fork of said mod, renamed it so it doesn't get flagged, and have had 0 issues for the current 700 hours I have into the save, so seems to work just fine to me.

ArchEzekiel commented 8 months ago

It's marked incompible because the system that's been designed is not implemented with other beacon mods in mind. The issue is clearly not " we don't like it" since the author of that mod AND py dev, notnotmelon, flagged it incompatible themself, as Septiple mentioned

pyanodon / pybugreports