pyanodon / pybugreports

Central bug-report repository for pymods
The Unlicense
5 stars 1 forks source link

Asphalt migration script bug #416

Open KhonaB opened 5 months ago

KhonaB commented 5 months ago

Mod source

Factorio Mod Portal

Which mod are you having an issue with?

Operating system

=Windows 10

What kind of issue is this?

What is the problem?

When the asphalt was accidentally transmuted into lab tiles a few patches ago, the migration script appears to have erroneously converted both the "built tile" layer and the "terrain tile" layer into asphalt. This means that when the new asphalt tiles are mined (returning one asphalt), there's still asphalt underneath. Moreover, this "terrain tile" asphalt can be harvested by building new tiles on top of it, returning a second piece of asphalt, and inserting the new built tile in the "terrain tile" layer.

I suggest a second migration script that converts specifically pY or vanilla "buildable" tiles (e.g. concrete, stone brick, limestone tile, asphalt, etc) that are placed in the "terrain layer" with grass tiles in the "terrain layer". While this would leave weird grass patches in deserts/red deserts/alien biomes, its probably the best that could be easily done (unless the terrain generator is easily accessed from script, in which case it could be simply regenerated according to biome--unless it regenerates to water, in which case it should be converted to landfill in the "terrain layer")

Steps to reproduce

Not quite sure how to reproduce other than on a save file that had asphalt on the ground during the appropriate patch cycles, but I could upload my save if necessary.

Additional context

No response

Log file

No response

kingarthur91 commented 4 months ago

ya if you still have a save file with that issue please send it. would make trying to fix the issue much easier than guessing and not being able to test it

KhonaB commented 4 months ago

First map is a map that exhibits that bug untouched (its literally my current game save) but the bug isn't very obvious, so the second map has all deconstructible tiles in the build layer removed (via deconstruction planner in god mode) leaving only the tiles that are erroneously in the terrain layer. I don't think there's any asphalt in the terrain layer where there's supposed to be water/landfill though, I fixed that manually a long time ago (because I put the landfill one tile off).

PyAE2.zip test.zip

notnotmelon commented 1 month ago

Thanks for the report.

I'm closing this. Considering that this is a migration issue, it does not effect new users. I recommend to use the /editor to fix this if your base still has issues.

notnotmelon commented 1 month ago

Reopening due to compatibility issues with Editor Extensions.