pyanodon / pybugreports

Central bug-report repository for pymods
The Unlicense
5 stars 1 forks source link

popping sound/ noise in the sound effect for spore collector (mk02 is where I specifically heard it, but prolly all of them) #421

Closed WarlordFTW closed 3 months ago

WarlordFTW commented 5 months ago

Mod source

Factorio Mod Portal

Which mod are you having an issue with?

Operating system

=Windows 10

What kind of issue is this?

What is the problem?

I think title is self explanatory

Steps to reproduce

1.place spore collector mk2 down

  1. power it and select recipe (in my case yaedol turd recipe)
  2. go to map view
  3. zoom in
  4. listen

Additional context

No response

Log file

No response

WarlordFTW commented 5 months ago

I just checked and this is not present in mk1 spore collectors. The sound for the mk2 collector also seems louder. so it might be clipping and not the audio itself that's the problem.

notnotmelon commented 3 months ago

That's strange. I checked the code and the sound definitions are exactly the same between mk levels.

notnotmelon commented 3 months ago

Thanks for the report. Fixed. https://github.com/pyanodon/pypostprocessing/commit/0f2de46582024a065e6c728a646e49467559dd55