empty-barrel recipe should not define product as catalyst

SWeini commented 2 months ago

Mod source

Factorio Mod Portal

Which mod are you having an issue with?

[ ] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[X] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[X] Other

What is the problem?

Bad effects of this:

1) productivity modules are allowed but don't have an effect on the recipe 2) production statistics don't show the real number of barrels that were made (I know that later the barrel count is weird because of proddable barrel recipes (e.g. Arqad jelly barrel with the prod T.U.R.D.), but in the early game it's even weirder right now. I can only see the barrels I hand-crafted, they are probably counted differently.

It's probably a PyPP issue that marks all barrels in recipes as catalyst. The empty-milk-barrel, empty-jerry-can and empty-gas-canister recipes have the same issue, maybe there are even more.

Steps to reproduce

No response

Additional context

No response

Log file

No response

oorzkws commented 2 months ago

Good catch, thanks for the report!

oorzkws commented 2 months ago

ref: https://github.com/pyanodon/pypostprocessing/commit/f60365084c51d2595fe1d7d73b6b7ea2d606778e

oorzkws commented 2 months ago

https://github.com/pyanodon/pypostprocessing/commit/dfa720e2cb23a01a46a1613dda7dc0f4fe09011a

oorzkws commented 1 month ago

Resolved in https://github.com/pyanodon/pypostprocessing/commit/832afa5ee544e6468e54fd694bc719a66188daa1

pyanodon / pybugreports