Closed tlambert03 closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
65b221e
) to head (74a14e2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Czaki, with this PR, you should be able to use your own Action
subclass.
Action
CommandRegistry
(note that there is now a CommandRegistry.register_action
method that you can extend/override)CommandRegistry
subclass type here when you initialize your app (e.g. super().__init__(app_name, raise_synchronous_exceptions=True, commands_reg_class=NapariCommandRegistry)
This PR moves some of the logic in the
register_action
function into methods on the registries themselves. This will make it easier for custom subclasses of registries to control exactly how they register actions.It has some relatively inconsequential other stuff, like making
RegisteredCommand
immutable and public