search

pyapp-kit / app-model

Generic application schema implemented in python.
https://app-model.rtfd.io
BSD 3-Clause "New" or "Revised" License
18 stars 12 forks source link

feat: Include command/control-0 for OriginalSize in StandardKeyBindings #220

Closed psobolewskiPhD closed 1 month ago

psobolewskiPhD commented 1 month ago

I just discovered the very cool StandardKeyBindings while adding Zoom keybindings in napari. In this PR I'm just adding the command/control-0 to reset zoom as a standard keybinding, sometimes called OriginalSize (Qt), Actual Size (macOS), etc. but a consistent pattern on macOS and Windows and in Qt (https://doc.qt.io/qtcreator/creator-keyboard-shortcuts.html#image-viewer-shortcuts).

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (4afa6f6) to head (1c1c4ea). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #220 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 31 31 Lines 1870 1871 +1 ========================================= + Hits 1870 1871 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DragaDoncila commented 2 weeks ago

@tlambert03 it would be nice to have this PR released so we can merge a related PR in napari. Any chance of an app-model release soonish?

tlambert03 commented 2 weeks ago

just pushed v0.3.0, lemme know if the release fails for any reason