search

pyapp-kit / magicgui

build GUIs from type annotations
https://pyapp-kit.github.io/magicgui/
MIT License
362 stars 49 forks source link

Ensure QImage is ARGB32 before converting to numpy #618

Closed aganders3 closed 10 months ago

aganders3 commented 10 months ago

Closes #617

Thanks for pointing out the fix in napari - I just copied the code from there. I think convertTo might avoid the copy when unnecessary as well, but it was introduced in 5.13 so this seems safer.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (33c5e60) 87.73% compared to head (b59306a) 87.70%.

Files Patch % Lines
src/magicgui/backends/_qtpy/widgets.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #618 +/- ## ========================================== - Coverage 87.73% 87.70% -0.04% ========================================== Files 40 40 Lines 4722 4724 +2 ========================================== Hits 4143 4143 - Misses 579 581 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 10 months ago

included in v0.8.1, building now