pyapp-kit / magicgui

build GUIs from type annotations
https://pyapp-kit.github.io/magicgui/
MIT License
362 stars 49 forks source link

fix: Fix checking sublcasses of Future #665

Closed Czaki closed 1 month ago

Czaki commented 2 months ago

Fixes: https://github.com/napari/napari/pull/7130#issuecomment-2269119355

When creating and testing #658 I have missed the case of registering Futures. This PR is fixing this.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.16%. Comparing base (9776992) to head (b9c013b).

Files Patch % Lines
src/magicgui/_util.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #665 +/- ## ========================================== - Coverage 89.18% 89.16% -0.02% ========================================== Files 39 39 Lines 4742 4746 +4 ========================================== + Hits 4229 4232 +3 - Misses 513 514 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.