search

pyapp-kit / ndv

Simple, fast-loading, n-dimensional array viewer with minimal dependencies.
BSD 3-Clause "New" or "Revised" License
29 stars 4 forks source link

feat: enable 3d for pygfx #15

Closed tlambert03 closed 1 month ago

tlambert03 commented 1 month ago

there is a remaining bug/issue: after spending some time with it, I still can't get the pygfx orbit camera to rotate around the middle of the volume. will have to tackle it later

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.27119% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (95017fa) to head (187dfd3).

:exclamation: Current head 187dfd3 differs from pull request most recent head fb7a174

Please upload reports for the commit fb7a174 to get more accurate results.

Files Patch % Lines
src/ndv/viewer/_backends/_pygfx.py 75.00% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15 +/- ## =========================================== + Coverage 70.90% 81.43% +10.53% =========================================== Files 13 13 Lines 1172 1212 +40 =========================================== + Hits 831 987 +156 + Misses 341 225 -116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.