Closed hanjinliu closed 1 month ago
Attention: Patch coverage is 83.33333%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 81.93%. Comparing base (
e606d53
) to head (4cf3f81
).
Files | Patch % | Lines |
---|---|---|
src/ndv/viewer/_backends/_vispy.py | 66.66% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @hanjinliu, lovely seeing you here! 😀
I saw this as well and added https://github.com/pyapp-kit/superqt/issues/247 to superqt (which is in the latest release)... but I haven't tested on windows yet!
Are you definitely updated on superqt?
Hi @tlambert03, I'm very excited about this package!
Sorry for not carefully checking the update... I was using superqt=0.6.6
and the latest version did solve the issue with my local windows laptop.
Great! Good to hear :)
Shall we still turn this PR into fixing whatever else is left for windows tests?
(It's ok if we need to make some leak concessions, as you'll see I've already done with Linux)
Other fixes will be completely different from what I did here anyway. I think we can just close this PR and make new one later when the solution is found.
Ok well thanks for popping in!
Maybe related to #8. I found that
qthrottled
holds the reference to the widget instance (viamethod.__self__
?) and this prevented proper cleanups in Windows. This problem can be solved by using an weak reference inside a local function as is done in this PR, but probably should be somehow handled onsuperqt
side (although I'm not sure if it's possible).