pyapp-kit / ndv

Simple, fast-loading, n-dimensional array viewer with minimal dependencies.
BSD 3-Clause "New" or "Revised" License
35 stars 5 forks source link

working on general model refactor #33

Open tlambert03 opened 3 months ago

tlambert03 commented 3 months ago

this PR is not necessarily for merging, but rather for discussing high level model and control flow. I want to step back and reconsider the model carefully. ndv is "doing a thing" somewhat nicely, and it's a good time to step back and clarify exactly what that thing is, with an eye towards building a better foundation to fix some issues (i.e. channel-specific lut persistence) and prepare for some nice features (i.e. chunked loading #22)

cc @alisterburt @hanjinliu, inasmuch as you're looking at this repo these days, would love your feedback!

Main players here are:

I'll keep tweaking and updating this flow here, and then actually implement it later

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.27%. Comparing base (4e0c5fe) to head (d536b59).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 81.95% 74.27% -7.69% ========================================== Files 13 13 Lines 1236 1236 ========================================== - Hits 1013 918 -95 - Misses 223 318 +95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hanjinliu commented 3 months ago

Hi @tlambert03, thanks for tagging me. I think it's a nice idea to reconsider the class designs at this point. I'll look into this PR in detail little by little, and leave some comments if I found something might be relevant.

alisterburt commented 3 months ago

I love what I'm seeing at first pass, feels very nice but I need some time to integrate the whole model - need to think a little more on the index/bounds and how this might work/not work with oblique planes... interesting to think about!