Closed tlambert03 closed 1 year ago
Comparing tlambert03:fix-root-validators
(c85743f) with main
(1255291)
✅ 66
untouched benchmarks
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
1255291
) 100.00% compared to head (c85743f
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As discussed in #233, it probably also makes sense to rename property_dependencies
with this solution. That doesn't have to happen in this PR, but there should be an issue to track it if this is merged without.
agreed, did you have a thought on the exact name? As mentioned over there:
I like
dependencies
, but since the namespace is shared with all the other pydantic stuff, perhapsevent_dependencies
is safer/clearer? or do you likefield_dependencies
better thanevent_dependencies
?
fixes #233
@andy-sweet, this implements option number 2 from https://github.com/pyapp-kit/psygnal/issues/233#issuecomment-1722301583
property_dependencies
can include any field names ... not just property setters