Closed Czaki closed 8 months ago
Comparing Czaki:speedup_evented_set
(0ab5fc5) with main
(459828c)
⚡ 1
improvements
✅ 65
untouched benchmarks
Benchmark | main |
Czaki:speedup_evented_set |
Change | |
---|---|---|---|---|
⚡ | test_create_signal |
141.1 µs | 126.8 µs | +11.28% |
When developing locally, pre-commit
complains about line length, but I do not know how to break type declaration.
Also, mypy report problems with lack of Self (I see that on Ci, it does not happen).
I need to add type casting for reducer to satisfy mypy.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
459828c
) 100.00% compared to head (0ab5fc5
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
(Should I add benchmarks to tests/test_bench
)?
(Should I add benchmarks to tests/test_bench)?
it's ok. the asv benchmarks are nice because they can run retrospectively (and show the speedup you gained here), whereas codspeed and test_bench
can only start measuring going forward. I like codspeed in general, but the lack of retrospective monitoring is a bummer, so the one you added to asv is good enough
In this PR I have added an option for the combiner function to consume the whole list of tuples at once.