Closed Czaki closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ab5dfc5
) 100.00% compared to head (9ec3f99
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Comparing Czaki:remove_reducer_call_on_no_slot
(9ec3f99) with main
(ab5dfc5)
✅ 66
untouched benchmarks
Should I add test for it? (some mocking of reducer)
works for me!
Should I add test for it? (some mocking of reducer)
normally i'd say don't bother, but since we've got 100% coverage here, might as well keep it :)
actually... it's fine. the logic is so simple, and it does get covered by tests already. will merge. thanks!
This is followup to #277
Remove the whole reducing operation if there is no callback.