pyapp-kit / psygnal

Python observer pattern (callback/event system). Modeled after Qt Signals & Slots (but independent of Qt)
https://psygnal.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
84 stars 13 forks source link

A bit more consistent SignalGroup iter #289

Closed getzze closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f4ac7c3) to head (f8e9906).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 1930 1933 +3 ========================================= + Hits 1930 1933 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 7 months ago

CodSpeed Performance Report

Merging #289 will improve performances by 13.72%

Comparing getzze:correct-group-iter (f8e9906) with main (f4ac7c3)

Summary

⚡ 1 improvements ✅ 65 untouched benchmarks

Benchmarks breakdown

Benchmark main getzze:correct-group-iter Change
test_emit_time[lambda-2] 127.9 µs 112.5 µs +13.72%
tlambert03 commented 7 months ago

looks good to me! thanks @getzze.
side question: I notice you mark most of your PRs as draft, and don't seem to mark them as ready for review. Should I assume that they're ready to go if all tests are passing and you haven't touched it for a few days?

getzze commented 7 months ago

I'm not 100% when to use draft or not, but this PR is not a draft indeed :)