pyapp-kit / psygnal

Python observer pattern (callback/event system). Modeled after Qt Signals & Slots (but independent of Qt)
https://psygnal.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
84 stars 13 forks source link

chore: patch asv config to work locally with arm64 macos on hatchling #294

Closed tlambert03 closed 7 months ago

tlambert03 commented 7 months ago

this is an ugly fix to deal with the fact that hatchling doesn't respect MACOSX_DEPLOYMENT_TARGET, and when I try to run asv benchmarks locally, the wheel that gets created is doesn't get interpreted as compatible with the system, and can't be installed. One fix is to set macos-max-compat = false in the hatch wheel settings, but I only want that to happen when benchmarking locally, and that setting doesn't seem to be switchable by an environment variable. so this is the unfortunate solution I came up with.

inspired by black's pyproject: https://github.com/psf/black/blob/6af7d1109693c4ad3af08ecbc34649c232b47a6d/pyproject.toml

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f4ac7c3) to head (f7d0785).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #294 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 1930 1930 ========================================= Hits 1930 1930 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 7 months ago

CodSpeed Performance Report

Merging #294 will not alter performance

Comparing tlambert03:fix-asv-local (f7d0785) with main (f4ac7c3)

Summary

✅ 66 untouched benchmarks