search

pyapp-kit / psygnal

Python observer pattern (callback/event system). Modeled after Qt Signals & Slots (but independent of Qt)
https://psygnal.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
86 stars 15 forks source link

feat: make SignalGroupDescriptor generic #297

Open tlambert03 opened 8 months ago

tlambert03 commented 8 months ago

This PR is carrying on what I tried to do in #291.

It all works, but makes for an unappealing consequence when annotating with ClassVar[SignalGroupDescriptor] as described in https://github.com/pyapp-kit/psygnal/pull/291#issuecomment-1988739365

working on it here

codspeed-hq[bot] commented 8 months ago

CodSpeed Performance Report

Merging #297 will not alter performance

Comparing tlambert03:generic-sig-group-decriptor (d4c196e) with main (2143681)

Summary

✅ 66 untouched benchmarks

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2143681) to head (d4c196e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #297 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 1986 1987 +1 ========================================= + Hits 1986 1987 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.