search

pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
210 stars 38 forks source link

Bump qtpy to at least 1.10 #112

Closed Czaki closed 2 years ago

Czaki commented 2 years ago

To import SignalInstance from qtpy.QtCore the minimum version of qtpy is 1.10

tlambert03 commented 2 years ago

as far as I can tell, SignalInstance is only imported in one place, and under a TYPE_CHECKING clause:

https://github.com/napari/superqt/blob/a3bd0d0edf046680bde3dabd653138749a02a20d/src/superqt/utils/_throttler.py#L38

so it shouldn't be required for runtime... what did you run into?

Czaki commented 2 years ago

Ahh. The old release does not have a guard check,

https://github.com/napari/napari/runs/8043776391?check_suite_focus=true#step:8:80

tlambert03 commented 2 years ago

ah, yep. that was fixed in https://github.com/napari/superqt/pull/70/

tlambert03 commented 2 years ago

you could bump napari's requirements to https://github.com/napari/superqt/releases/tag/v0.3.1 if you want

Czaki commented 2 years ago

you could bump napari's requirements to v0.3.1 (release) if you want

I just bump qtpy, so it solves the problem from this side.