search

pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
210 stars 38 forks source link

Enum ComboBox implementation #13

Closed Czaki closed 3 years ago

Czaki commented 3 years ago

This PR add Enum ComboBox to superqt. Enum is quite popular method of limit selection of options so it will be nice to simplify using it from interface.

tlambert03 commented 3 years ago

This looks pretty good to me @Czaki! Anything else that needs to be done?

Czaki commented 3 years ago

This looks pretty good to me @Czaki! Anything else that needs to be done?

I need to finish the documentation. It`s a little late for me so I will do this tomorrow.

Czaki commented 3 years ago

I add a little text to docs and allow to use Optional[Enum] as type.

Czaki commented 3 years ago

Hm, maybe need to add information about a new signal in documentation?

tlambert03 commented 3 years ago

sounds good. ping me when you're happy with it

tlambert03 commented 3 years ago

docs look good to me. Still want more time with this @Czaki?

Czaki commented 3 years ago

No. Ready to merge.

tlambert03 commented 3 years ago

thanks @Czaki!