search

pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
210 stars 38 forks source link

fix: remove dupes/aliases in QEnumCombo #190

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

This PR removes duplicates/aliases from showing up in a QEnumCombo:

class MyEnum(Enum):
    VALUE = 'value'
    ALIAS = VALUE

should only show 'value' once, not twice

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (619daae) 86.30% compared to head (3f02063) 86.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## ======================================= Coverage 86.30% 86.31% ======================================= Files 36 36 Lines 2783 2785 +2 ======================================= + Hits 2402 2404 +2 Misses 381 381 ``` | [Files Changed](https://app.codecov.io/gh/pyapp-kit/superqt/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyapp-kit) | Coverage Δ | | |---|---|---| | [src/superqt/combobox/\_enum\_combobox.py](https://app.codecov.io/gh/pyapp-kit/superqt/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyapp-kit#diff-c3JjL3N1cGVycXQvY29tYm9ib3gvX2VudW1fY29tYm9ib3gucHk=) | `94.02% <100.00%> (+0.18%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.