pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
207 stars 36 forks source link

fix: fix a number of issues with Labeled and Range Sliders, add LabelsOnHandle mode. #242

Closed tlambert03 closed 6 months ago

tlambert03 commented 6 months ago

This PR fixes a variety of issues I've encountered, mostly with labeled sliders:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 12 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@12f10be). Click here to learn what that means.

Files Patch % Lines
src/superqt/sliders/_labeled.py 71.05% 11 Missing :warning:
src/superqt/sliders/_generic_slider.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #242 +/- ## ======================================= Coverage ? 87.08% ======================================= Files ? 46 Lines ? 3398 Branches ? 0 ======================================= Hits ? 2959 Misses ? 439 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.