tlambert03 commented 3 years ago

PR that will remove qtcompat and use qtpy again once the qt6 support is realeased.

codecov-commenter commented 3 years ago

Codecov Report

Merging #39 (925667f) into main (bbd60ee) will decrease coverage by 0.27%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   84.83%   84.55%   -0.28%     
==========================================
  Files          27       24       -3     
  Lines        2169     2104      -65     
==========================================
- Hits         1840     1779      -61     
+ Misses        329      325       -4

Impacted Files	Coverage Δ
src/superqt/fonticon/__init__.py	`88.88% <ø> (ø)`
src/superqt/qtcompat/__init__.py	`0.00% <0.00%> (-72.92%)`	:arrow_down:
src/superqt/_eliding_label.py	`100.00% <100.00%> (ø)`
src/superqt/collapsible/_collapsible.py	`97.18% <100.00%> (ø)`
src/superqt/combobox/_enum_combobox.py	`93.84% <100.00%> (ø)`
src/superqt/fonticon/_animations.py	`100.00% <100.00%> (ø)`
src/superqt/fonticon/_qfont_icon.py	`93.43% <100.00%> (ø)`
src/superqt/sliders/_generic_range_slider.py	`89.00% <100.00%> (ø)`
src/superqt/sliders/_generic_slider.py	`89.13% <100.00%> (-0.32%)`	:arrow_down:
src/superqt/sliders/_labeled.py	`82.47% <100.00%> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbd60ee...925667f. Read the comment docs.

tlambert03 commented 3 years ago

this still needs https://github.com/spyder-ide/qtpy/pull/276 and https://github.com/spyder-ide/qtpy/pull/271 before we could use qtpy again

pyapp-kit / superqt

Use qtpy, deprecate superqt.qtcompat, drop support for Qt <5.12 #39

Codecov Report