search

pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
210 stars 38 forks source link

add edgeLabelMode option to QLabeledSlider #59

Closed tlambert03 closed 2 years ago

tlambert03 commented 2 years ago

with @brisvag

Adds the option to toggle labels on QLabeledSlider using sld.setEdgeLabelMode(mode) where mode is one of sld.EdgeLabelMode.NoLabel or sld.EdgeLabelMode.LabelIsValue

closes #49

codecov[bot] commented 2 years ago

Codecov Report

Merging #59 (a49bcd7) into main (329eaaa) will decrease coverage by 0.59%. The diff coverage is 34.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   84.58%   83.98%   -0.60%     
==========================================
  Files          24       24              
  Lines        2108     2129      +21     
==========================================
+ Hits         1783     1788       +5     
- Misses        325      341      +16
Impacted Files Coverage Δ
src/superqt/sliders/_labeled.py 79.79% <34.78%> (-2.87%) :arrow_down:
src/superqt/sliders/_range_style.py 71.42% <0.00%> (-0.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 329eaaa...a49bcd7. Read the comment docs.

brisvag commented 2 years ago

Supersedes #49!

tlambert03 commented 2 years ago

merging since the windows fails are the whole xvfb deal