search

pyapp-kit / superqt

Missing widgets and components for Qt-python
https://pyapp-kit.github.io/superqt/
BSD 3-Clause "New" or "Revised" License
215 stars 38 forks source link

Reorder label update signal #83

Closed tlambert03 closed 2 years ago

tlambert03 commented 2 years ago

minor change on the order of operations when updating a labeled slider

codecov[bot] commented 2 years ago

Codecov Report

Merging #83 (8aa6514) into main (bd6fba9) will increase coverage by 0.32%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   84.23%   84.55%   +0.32%     
==========================================
  Files          26       29       +3     
  Lines        2258     2325      +67     
==========================================
+ Hits         1902     1966      +64     
- Misses        356      359       +3
Impacted Files Coverage Δ
src/superqt/sliders/_labeled.py 79.79% <100.00%> (ø)
src/superqt/__init__.py 100.00% <0.00%> (ø)
src/superqt/combobox/__init__.py 100.00% <0.00%> (ø)
src/superqt/selection/_searchable_list_widget.py 96.96% <0.00%> (ø)
src/superqt/combobox/_searchable_combo_box.py 93.33% <0.00%> (ø)
src/superqt/selection/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd6fba9...8aa6514. Read the comment docs.