search

pyatyispyatil / flame-chart-js

Extensible component for incredibly fast viewing of flame charts
https://pyatyispyatil.github.io/flame-chart-js/
MIT License
100 stars 23 forks source link

Implemented setting types #28

Closed pyatyispyatil closed 2 years ago

pyatyispyatil commented 2 years ago

There are many changes, as well as one critical change with the settings structure. I couldn't come up with strong types to implement the old settings, and I had to change the signature of the public setSettings method.

Also I found one eslint rule that conflicts with another @typescript-eslint/consistent-type-imports <-> no-duplicate-imports And I decided to remove @typescript-eslint/consistent-type-imports and I think that we should use only the classic import.

pyatyispyatil commented 2 years ago

And about DX - now it's not very good. I think we should consider switching to another transpiler, or we should do a normal watch mode with the current build.)

Smrtnyk commented 2 years ago

And about DX - now it's not very good. I think we should consider switching to another transpiler, or we should do a normal watch mode with the current build.)

we could use concurrently with tsc watch + esbuild watch esbuild could be a bundler and minifier, it is extremely fast but not sure if that is what you thought? to after you change the typescript, that example dir is also built?

Smrtnyk commented 2 years ago

Wow, you really nailed it man, your work is so inspiring :) will have much fun reviewing and learning from your changes

pyatyispyatil commented 2 years ago

we could use concurrently with tsc watch + esbuild watch esbuild could be a bundler and minifier, it is extremely fast but not sure if that is what you thought? to after you change the typescript, that example dir is also built?

Well, I just now tried setting up the rollup watch mode with ts and it works.) Looks like my DX issues are gone and we can work with the current build config.

In this PR I will add new configuration and update script for development - npm run watch

pyatyispyatil commented 2 years ago

@Smrtnyk please check the latest commit. I have added some changes to the build configuration.

Smrtnyk commented 2 years ago

@Smrtnyk please check the latest commit. I have added some changes to the build configuration.

LGTM, amazing work