search

pyatyispyatil / flame-chart-js

Extensible component for incredibly fast viewing of flame charts
https://pyatyispyatil.github.io/flame-chart-js/
MIT License
100 stars 23 forks source link

feat(intervals): add basic support for intervals #37

Open Smrtnyk opened 1 year ago

Smrtnyk commented 1 year ago

For now it just renders the intervals on the chart. It uses pink stripes and alpha transparency rects to preserve the parent fill color. In future will add tooltip rendering to intervals and proper self time calculation for parent node to show active self time and interval time

pyatyispyatil commented 1 year ago

Sorry for the long absence. I finally freed myself and now I can devote my time to open source.)

Smrtnyk commented 1 year ago

Sorry for the long absence. I finally freed myself and now I can devote my time to open source.)

Thanks for the review, unfortunately I am away from laptop until 9th january, doing vacation, so won't be able to do any code. Will only check stuff on the phone. If you feel to push something on top of this feel free, otherwise I will try to implement your suggestions when I am back.

Its nice to see you back, hope everything is going fine for you.