Bug: Plugin on select doesn't work for index zero on waterfall plugin and possibly other plugins that have handle select

pyatyispyatil / flame-chart-js

Extensible component for incredibly fast viewing of flame charts

https://pyatyispyatil.github.io/flame-chart-js/

MIT License

100 stars 23 forks source link

Bug: Plugin on select doesn't work for index zero on waterfall plugin and possibly other plugins that have handle select #61

Closed wizardlyhel closed 10 months ago

wizardlyhel commented 10 months ago

When handling selected region in a plugin, if region.data === 0, null is returned. However, this.initialData[0] is a valid region and should return data instead of null

https://github.com/pyatyispyatil/flame-chart-js/blob/fe2fe15df8e4ce542e984ed02fd5876d7298daa7/src/plugins/waterfall-plugin.ts#L87-L89

pyatyispyatil commented 10 months ago

Thank you very much for your bug report! =)

Fixed in 3.2.0