Add optional image parameter to provisioning_uri

pyauth / pyotp

Python One-Time Password Library

https://pyauth.github.io/pyotp/

Other

3.03k stars 326 forks source link

Closed ddboline closed 3 years ago

ddboline commented 3 years ago

This PR adds an optional image parameter to the uri returned by provisioning_uri.

The image parameter allows for the inclusion of a logo in the Authy and FreeOTP apps.

I did this without realizing there was an existing issue: https://github.com/pyauth/pyotp/issues/96

kislyuk commented 3 years ago

Thanks for the PR, it looks good overall.

Could you please:

Parse the image URL with urlparse and assert that the scheme, netloc and path are not empty
Parse the image URL with urlparse and assert that the scheme is https
Add this parameter to one of the tests in the test suite

ddboline commented 3 years ago

@kislyuk I've updated the PR.

kislyuk commented 3 years ago

Thanks so much for your high quality contribution, I really appreciate it.

I will roll a release with this functionality soon.

kislyuk commented 3 years ago

Released in v2.5.0, please test.

ddboline commented 3 years ago

Thanks @kislyuk I created an MR to fix a small issue: https://github.com/pyauth/pyotp/pull/114