search

pyauth / pyotp

Python One-Time Password Library
https://pyauth.github.io/pyotp/
Other
2.97k stars 323 forks source link

Add color option for provisioning uri. #164

Closed hmartinet closed 5 months ago

hmartinet commented 5 months ago

Add color option for provisioning uri and allow parse_uri to accept optional color uri parameter.

The color option is used by FreeOTP with image option: https://github.com/npmccallum/freeotp-android/blob/master/URI.md

kislyuk commented 5 months ago

Thank you for your interest in PyOTP.

The image and color otpauth URI scheme parameters are non-standard extensions and are not supported outside FreeOTP. Because only one counterparty supports them, we will not support the color parameter explicitly.

However, the otpauth URI scheme specifically describes the ability for implementations to use custom parameters. I've pushed a commit to remove explicit support for the image parameter and replace it with a change that accepts freeform parameters (including image and color) instead.

hmartinet commented 5 months ago

Hello,

I think it's better to use all the custom arguments as you've done. Other OTP apps ignore them. I did it this way, inspired by what had been done for image, but I thought it would be better to use the arguments provided agnostically without refusing them.

Thank you.

The link to your commit for history: 249674bf2814e1fcc3152c618514159cd44b4610