search

pyauth / pyotp

Python One-Time Password Library
https://pyauth.github.io/pyotp/
Other
3k stars 324 forks source link

Single issuer_name filter #50

Closed ghost closed 7 years ago

ghost commented 7 years ago

The issuer_name is no longer double filtered as shown in issue #49.

ghost commented 7 years ago

If I'm not mistaken, this works despite the failed CI tests. Let me know if you yourself see any issues with it.

tilkinsc commented 7 years ago

iirc the pypy test failed.

ghost commented 7 years ago

@Hydroque I see each of the tests failed, however, I can personally attest that it works perfectly through pypy and Python 3.6. The Travis-CI test for this version failed (here), which leads me to believe the tests are not correctly set. I would appreciate if someone could run this on a 2.7, 3.3, 3.4, and/or 3.5 and post a comment with the results.

tilkinsc commented 7 years ago

Isn't there anything comprehensive that will tell you why they failed o.o

ghost commented 7 years ago

Well if you look at the link from my last post, you can see the whole log of all the tests performed on the package and exactly where it failed. The initial issue regarding the issuer name was that it wasn't properly encoding some special characters for some 2FA applications. The merged code fixes that issue, however it is my belief the tests were not updated to check against the new scheme.

kislyuk commented 7 years ago

I did update the tests, and they pass on master.