search

pyauth / pyotp

Python One-Time Password Library
https://pyauth.github.io/pyotp/
Other
3.03k stars 326 forks source link

Add support for parsing provisioning URIs #84

Closed TheLastProject closed 5 years ago

TheLastProject commented 5 years ago

I hope this could be valuable to this project

codecov-io commented 5 years ago

Codecov Report

Merging #84 into master will decrease coverage by 2.8%. The diff coverage is 86.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   97.91%   95.11%   -2.81%     
==========================================
  Files           8        8              
  Lines         335      409      +74     
==========================================
+ Hits          328      389      +61     
- Misses          7       20      +13
Impacted Files Coverage Δ
src/pyotp/hotp.py 100% <100%> (ø) :arrow_up:
src/pyotp/utils.py 95.83% <100%> (ø) :arrow_up:
src/pyotp/totp.py 100% <100%> (ø) :arrow_up:
src/pyotp/__init__.py 83.87% <79.59%> (-16.13%) :arrow_down:
src/pyotp/otp.py 97.5% <87.5%> (-2.5%) :arrow_down:
test.py 96.58% <93.75%> (-0.79%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 041f5d3...5d7bf9d. Read the comment docs.

TheLastProject commented 5 years ago

Using this functionality in one of my projects right now, I can confirm it works really well in practice:

https://github.com/Pext/pext_module_pass/commit/3bdf2e15e3161b04dc5b8d7f66a0950462b5e65c

TheLastProject commented 5 years ago

I've restored the old arguments (they now override anything possibly imported)