search

pyauth / python-pkcs11

PKCS#11/Cryptoki support for Python
MIT License
150 stars 71 forks source link

KeyType.EC_EDWARDS in test_sign_eddsa #143

Open HRio opened 2 years ago

HRio commented 2 years ago

The KeyType should be EC_EDWARDS for Ed25519

Fixes:

 BotanECDSA.cpp(301): ECDSA key generation failed

i.e. SoftHSM goes into BotanECDSA.cpp instead of BotanEDDSA.cpp where 1.3.101.112 is handled

paravoid commented 1 year ago

+1, and this addresses a test failure on Debian as well.

One semi-related note is that the comment right below this line says to use "Ed25519" once https://github.com/wbond/asn1crypto/pull/134 is merged, and that has happened already: this is commit https://github.com/wbond/asn1crypto/commit/07b630545c075ace93b1ecfcce2ae843ca88fa99 included in asn1crypto 1.5.0.

While at it, it may be worth to just bump the dependency and replace "1.3.101.112" by "ed25519".