search

pyavitz / rpi-img-builder

Image Builder for the Raspberry Pi
Other
166 stars 31 forks source link

WIP: adds ability to configure rpi hostname, BRANDING & motd at buildtime #51

Closed adam-burns closed 1 year ago

pyavitz commented 1 year ago

If anything breaks, you gotta fix it :)

pyavitz commented 1 year ago

Reverting

+ mkdir -p /etc/update-motd.d
+ [[ -f /etc/update-motd.d/10-uname ]]
+ rm -f /etc/update-motd.d/10-uname
+ [[ -f /etc/update-motd.d/10-help-text ]]
+ [[ -f /etc/update-motd.d/00-header ]]
+ mv -f 00-header 15-brand 20-sysinfo 90-dynamic-motd /etc/update-motd.d/
+ chmod +x /etc/update-motd.d/00-header /etc/update-motd.d/15-brand /etc/update-motd.d/20-sysinfo /etc/update-motd.d/90-dynamic-motd
+ echo '# DYNAMIC MOTD VARIABLES'
+ echo H_POS=-c
+ echo B_POS=-r
+ echo BRANDING=false
/root/stage2: line 255: DEFAULT_MOTD: unbound variable
make: *** [Makefile:130: image] Error 1

Also creating a custom hostname is already apart of the credentials service, so I think this may create a conflict. Have you considered using the userscripts feature? With that you can make edits to the builder during stage1 and stage2.

https://github.com/pyavitz/rpi-img-builder/tree/master/files/userscripts