pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.09k stars 537 forks source link

The simulation terminated before the lower cut-off voltage reached #1637

Closed Leonhardup closed 3 years ago

Leonhardup commented 3 years ago

When I changed the C-rate, the terminal voltage can not reach the lower cut-off voltage but the simulation terminated before the setting solve time.

image

any ideas about this issues?

Leonhardup commented 3 years ago

the lower cut-off voltage is 2.5 V, but the voltage terminated above 3.0V. image

valentinsulzer commented 3 years ago

Probably similar to #1632 Can you print sim.solution.termination?

Leonhardup commented 3 years ago

Probably similar to #1632 Can you print sim.solution.termination?

Hello, tinosulzer! I printed the sim.solution.termination as "Termination:event: Maximum positive particle surface concentration". Do you have some ideas on my issue?

valentinsulzer commented 3 years ago

At this high C-rate (for an energy cell which is Chen2020) the simulation stops before the cut-off voltage is reached because the positive particles fill up first. But if you update to the latest version (on the develop branch) it might give you a different result

Leonhardup commented 3 years ago

At this high C-rate (for an energy cell which is Chen2020) the simulation stops before the cut-off voltage is reached because the positive particles fill up first. But if you update to the latest version (on the develop branch) it might give you a different result

Great, you mean it can be addressed by updating the latest Pybamm version?

valentinsulzer commented 3 years ago

Possibly, but the pypi release is not working right now, so you will have to clone the repository and install from source

Leonhardup commented 3 years ago

Possibly, but the pypi release is not working right now, so you will have to clone the repository and install from source

Thank you! I have cloned the repository by desktop, and how can I install from source?

valentinsulzer commented 3 years ago

https://pybamm.readthedocs.io/en/latest/install/install-from-source.html

valentinsulzer commented 3 years ago

any luck @Leonhardup ?

Leonhardup commented 3 years ago

any luck @Leonhardup ?

Hello, Tinosulzer! I have a problem in installing the latest version Pybamm from source in macOS . The CMake got wrong with "Bad CMake executable "". Is it installed or settings contain the correct path (cmake.cmakePath)?" When could the latest pybamm be released?

valentinsulzer commented 3 years ago

Which step is this?

Leonhardup commented 3 years ago

Which step is this?

Manual installing the build-time requirements, doesn't it use VS code?

valentinsulzer commented 3 years ago

If you did brew install sundials and installed pybind11 you don't need to do that step. Try just moving on to tox -e dev

valentinsulzer commented 3 years ago

Can you try updating to the latest version that was just released on pypi?

Leonhardup commented 3 years ago

Can you try updating to the latest version that was just released on pypi? Thanks for you attention! Is there a get-pip.py file to install the latest version?

Leonhardup commented 3 years ago

Can you try updating to the latest version that was just released on pypi?

image Is it successfully installed?

valentinsulzer commented 3 years ago

What does pip show pybamm give you?

Leonhardup commented 3 years ago

What does pip show pybamm give you?

image It is 21.8 version. Right?

valentinsulzer commented 3 years ago

Yes. Does it reach cut-off voltage now?

Leonhardup commented 3 years ago

Yes. Does it reach cut-off voltage now?

Yes, it can reach the lower cut-off voltage, but at some C-rate, the discharge terminal curve is a little weird, as the picture shows, the C-rate is 2C. Do you know why? image

valentinsulzer commented 3 years ago

This is probably the point where the electrolyte was depleted, can you plot "Electrolyte concentration"

Leonhardup commented 3 years ago

This is probably the point where the electrolyte was depleted, can you plot "Electrolyte concentration"

Hello, Tinosulzer! As for a single particle model, whose parameters set do you think should be the best for simulation?

valentinsulzer commented 3 years ago

You need to choose the appropriate parameter set to match your experimental data. If you don't have any experimental data then Chen2020 is a good place to start.

It sounds like this issue is fixed, I'm going to close it but can reopen if you have more questions