search

pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.12k stars 548 forks source link

BaseBatterySubmodel #2221

Open rtimms opened 2 years ago

rtimms commented 2 years ago

Make a BaseBatterySubmodel that performs things like checking domains, e.g.

        ok_domain_list = [
            "Negative",
            "Separator",
            "Positive",
            "Negative electrode",
            "Negative electrolyte",
            "Separator electrolyte",
            "Positive electrode",
            "Positive electrolyte",
            None,
        ]

so that BaseSubmodel is more general. Useful for training etc. to not be restricted to battery things when using submodels.

valentinsulzer commented 2 years ago

We could consider getting rid of those checks.

brosaplanella commented 2 years ago

Following our experience with the coord_sys, I think we should keep some checks somewhere in the battery submodels. But certainly not in the BaseSubmodel class.