Closed ejfdickinson closed 1 year ago
Simplest fix, if cause is what it looks like - use distinct variable names for all activation energies in bpx.py
.
Fixed as a pre-cursor to https://github.com/pybamm-team/PyBaMM/issues/3225
This PR now also fixes https://github.com/pybamm-team/PyBaMM/issues/3225
PyBaMM Version
23.4
Python Version
3.9.16
Describe the bug
When temperature-dependent functions are created in
create_from_bpx()
, the apparent activation energy for the following callable parameter definitions in the generatedparameter_values
instance is replaced by the value of"Electrolyte conductivity activation energy [J.mol-1]"
.This appears to be a late-binding bug due to the repeat use of non-local variable
E_a
in the declaration these functions, which is repeatedly redefined, the electrolyte conductivity activation energy being the last such redefinition.Affected functions:
Note: identified in 23.4 but no relevant code changes in latest version
Steps to Reproduce
Using
nmc_pouch_cell_BPX.json
from the BPX example download:Relevant log output