pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
876 stars 492 forks source link

Fixed broken link renders in SPM example notebook #4185

Closed santacodes closed 2 weeks ago

santacodes commented 2 weeks ago

Description

Removed the inline code to make the link reference render properly in the documentation.

Fixes #4181

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

review-notebook-app[bot] commented 2 weeks ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.58%. Comparing base (4d08b7a) to head (aaf12d4). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4185 +/- ## ======================================== Coverage 99.58% 99.58% ======================================== Files 288 288 Lines 21799 21799 ======================================== Hits 21708 21708 Misses 91 91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arjxn-py commented 2 weeks ago

@all-contributors please add @santacodes for code & infra

allcontributors[bot] commented 2 weeks ago

@arjxn-py

I've put up a pull request to add @santacodes! :tada: