Added contact resistance to model.

[parkec3]

Description

Added a term for the contact resistance within heating. Still needs to be tested for functionality as well as the typical tests. The contact resistance parameter within pybamm is [ohm] instead of [ohm m2], so I left off the surface area when calculating the heating term. The volume parameter also needs to be checked to ensure it's the correct volume calculation.

Fixes #4140

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• [x] New feature (non-breaking change which adds functionality)
• [ ] Optimization (back-end change that speeds up the code)
• [ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

• [ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• [ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• [ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• [ ] Code is commented, particularly in hard-to-understand areas
• [ ] Tests added that prove fix is effective or that feature works

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.54%. Comparing base (a786a5e) to head (1ba3b8d). Report is 2 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #4192 +/- ## =========================================== - Coverage 99.55% 99.54% -0.02% =========================================== Files 288 288 Lines 21878 21886 +8 =========================================== + Hits 21781 21786 +5 - Misses 97 100 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[rtimms]

It would also be good to update this notebook to include contact resistance heating in the lumped model. We should also update the docs of the thermal models to be more explicit about which heating terms are included.

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB