pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
876 stars 492 forks source link

Add smitasahu2 to contributors #4204

Closed brosaplanella closed 2 weeks ago

brosaplanella commented 2 weeks ago

Description

The all-contributors bot for some reason could not add Smita to the contributors, so done it locally with the CLI.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.59%. Comparing base (088ca38) to head (870d81f). Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4204 +/- ## =========================================== + Coverage 99.58% 99.59% +0.01% =========================================== Files 288 288 Lines 21799 21858 +59 =========================================== + Hits 21708 21770 +62 + Misses 91 88 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brosaplanella commented 2 weeks ago

Need to wait for a test to pass on #2837 (I believe it failed randomly), I will merge that one and then this one