pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
876 stars 492 forks source link

#4120 improved error message #4208

Closed Ubham16 closed 1 week ago

Ubham16 commented 1 week ago

Description

Added a more informative error message when I passed an invalid parameter set, which rejects that parameter set and relays a list of potential paramters that could be inputted

Fixes #4120

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.55%. Comparing base (205ca81) to head (e7ed6b8). Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4208 +/- ## ======================================== Coverage 99.55% 99.55% ======================================== Files 288 288 Lines 21857 21858 +1 ======================================== + Hits 21760 21761 +1 Misses 97 97 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rtimms commented 1 week ago

@all-contributors please add @Ubham16 for code

allcontributors[bot] commented 1 week ago

@rtimms

I've put up a pull request to add @Ubham16! :tada: