pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
876 stars 492 forks source link

Fix lychee issues from tinyurl #4219

Closed kratman closed 1 week ago

kratman commented 1 week ago

Description

Lychee was having issues with tinyurl, so this should avoid future issues.

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

kratman commented 1 week ago

I will mark this as ready for review after I test that the links still work in the docs

kratman commented 1 week ago

While the tinyurl issues could be intermittent like some of the stack overflow ones, some of them also pointed to old documentation. So getting rid of the obfuscation is a plus

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.55%. Comparing base (7ba74dc) to head (74381f7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4219 +/- ## =========================================== + Coverage 99.54% 99.55% +0.01% =========================================== Files 288 288 Lines 21858 21856 -2 =========================================== + Hits 21758 21759 +1 + Misses 100 97 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.