Closed pipliggins closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.54%. Comparing base (
e22d10c
) to head (6df0f92
). Report is 222 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rtimms Does this cover everything you wanted in #4119? The code looks fine to me, but I have not tested it myself
Description
Adds an OptionError if the option
SEI on cracks
is True butparticle mechanics
does not contain cracks. This issue only occurs if both options are set explicitly in the model's additional options - the user'sparticle mechanics
option overrides the defaults which automatically set the mechanics to "swelling and cracking" ifSEI on cracks
is true.Fixes #4119
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: