Closed MarcBerliner closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.55%. Comparing base (
e22d10c
) to head (e6decee
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For steps that compute their charge/discharge direction (Current
, CRate
, Power
, Resistance
), there were a few redundancies in the BaseStep
initialization. I moved the value_based_charge_or_discharge
inside the BaseStep
class and evaluate it after sanitizing the step value
. This should fix the codecov (I believe)
Description
Adds functionality to pass in arbitrary functions of time as the argument for a
pybamm.step
Fixes https://github.com/pybamm-team/PyBaMM/issues/4187
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
) (I haven't gottenidaklu
installed so I'm not certain all tests pass)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: