search

pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
876 stars 492 forks source link

remove python-idaklu #4223

Open martinjrobins opened 1 week ago

martinjrobins commented 1 week ago

Description

The python-idaklu solver is a legacy solver that uses idaklu but calls back into python for the functions. With the recent improvements to idaklu this can now be removed.

Motivation

reduce the number of solvers we need to maintain

Possible Implementation

No response

Additional context

No response

kratman commented 1 week ago

@martinjrobins It would be nice to break out idaklu into its own package within the PyBaMM ecosystem. That would let PyBaMM just install it as a library similar to how we install a casadi package. Is it feasible to do that along with removing the old solver?

agriyakhetarpal commented 1 week ago

It would be nice to break out idaklu into its own package within the PyBaMM ecosystem

Note for other readers: this was discussed in the monthly developer meeting in April and in the recent v24.5 release prep meeting. @Saransh-cpp reported that this could be a suitable 175-hour GSoC project