pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.08k stars 533 forks source link

Fix IDAKLU segfault with output variables #4379

Closed MarcBerliner closed 1 month ago

MarcBerliner commented 1 month ago

Description

Fixed a memory issue with output variables reported in #4375

Fixes #4375

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.46%. Comparing base (4d391fa) to head (efbed0e). Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4379 +/- ## ======================================== Coverage 99.46% 99.46% ======================================== Files 289 289 Lines 22200 22200 ======================================== Hits 22081 22081 Misses 119 119 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.