search

pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.11k stars 546 forks source link

Add CVODE solver #4407

Open MarcBerliner opened 2 months ago

MarcBerliner commented 2 months ago

Description

To improve the speed of our ODE models, I'd like to add CVODE from SUNDIALS to our suite of C solvers in addition to IDA.

More details in https://github.com/pybamm-team/PyBaMM/issues/3910#issuecomment-2312804655

Motivation

No response

Possible Implementation

No response

Additional context

No response

martinjrobins commented 1 month ago

I prefer the new name you suggested SundialsSolver (instead of IDAKLUSolver), makes sense. Have you started on this one yet and is there a branch I can have a look at ? I'd like to implement openmp parallisation for the SundialsSolver sometime soon (i.e. part of https://github.com/pybamm-team/PyBaMM/pull/4260) but can hold off if you have already started

MarcBerliner commented 1 month ago

I prefer the new name you suggested SundialsSolver (instead of IDAKLUSolver), makes sense. Have you started on this one yet and is there a branch I can have a look at ? I'd like to implement openmp parallisation for the SundialsSolver sometime soon (i.e. part of #4260) but can hold off if you have already started

I haven't started working on this yet.