search

pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.1k stars 541 forks source link

Use `numpy.typing.NDArray` instead of `np.ndarray` #4512

Open Saransh-cpp opened 4 days ago

Saransh-cpp commented 4 days ago

I noticed that pybamm uses np.ndarray everywhere, but we should use numpy.typing.NDArray wherever possible (everywhere). Ideally they should be swappable without any errors. Feel free to close this issue if there was a reason to specifically use np.ndarray.

sanjayh-2022 commented 4 days ago

I would like to work on this issue. Can i pick on this?

agriyakhetarpal commented 4 days ago

Hi @sanjayh-2022, sure! Please let us know if you need any help with this.