Closed aabills closed 2 weeks ago
reaction heating implemented but I think heat source is still inaccurate for half-cell models.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.29%. Comparing base (
19a7738
) to head (7678703
). Report is 3 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have found the second bug now. I think we should go ahead and merge this and discuss the second bug in a second issue, which I will open momentarily. The reason for a second PR is that the second bug could have ramifications outside of the files addressed in this pull request.
Not sure if we want to address this here or elsewhere (due to the second bug, this will fail for now), but I think we should start testing conservation of energy to catch stuff like this.
Description
Implements reaction heating in half cell models for the negative electrode
Fixes #4324
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: