pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.12k stars 547 forks source link

Throw an error when concatenations have different number of children #4562

Closed aabills closed 1 week ago

aabills commented 2 weeks ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4561

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

aabills commented 2 weeks ago

Tests are going to fail on this due to an unrelated issue that I am working on concurrently, so opening this for now and once we merge the other one we can merge this one.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.26%. Comparing base (1022c6b) to head (f313159). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4562 +/- ## =========================================== - Coverage 99.27% 99.26% -0.02% =========================================== Files 302 302 Lines 22868 22889 +21 =========================================== + Hits 22703 22721 +18 - Misses 165 168 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kratman commented 1 week ago

@aabills Can you update the bug fix section of the change log

aabills commented 1 week ago

@aabills Can you update the bug fix section of the change log

Done, I realized I haven't done that for the other PR's either so I did all 3.