Closed aabills closed 1 week ago
Tests are going to fail on this due to an unrelated issue that I am working on concurrently, so opening this for now and once we merge the other one we can merge this one.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.26%. Comparing base (
1022c6b
) to head (f313159
). Report is 3 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@aabills Can you update the bug fix section of the change log
@aabills Can you update the bug fix section of the change log
Done, I realized I haven't done that for the other PR's either so I did all 3.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #4561
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: